Shop Related Bugs.

[Impalix]

Before a statement is made about the auto-activate option under your account options, this bug does not fall into that category.

As you all know, I have a store full of all the ores and nuggets. Every day, I restock this store with new bits I find at the mine. There are already large amounts of both the ores and nuggets in my store, properly priced and activated to be seen in my store.

The problem is this.

When I add the new ores and nuggets, I add them without designating a new price (I add them at 0). My auto-activate function is not turned on. They simply add to the number of ores or nuggets I already have in the store at the same price already listed, BUT they disable the item altogether from my store. This does not seem correct as the items stock correctly but do not REMAIN stocked.

Assistance please?

[Gobberwart]

Ah, yep, I see the little bugger. Fixing it now.

[Impalix]

Thanks Gobb. I never thought I would actually find a bug :mrgreen:

[Gobberwart]

Fixed

[Grokly]

A probable side-effect to the fix on this bug is as follows:

1. I have auto-activate disabled in my profile options.
2. I have n number of an item in my store and active.
3. I add more of the same item, changing the price as I add them.
4. Items are added at the new price and remain active.

I would think that the same logic to protect someone from adding a new item to the store at an incorrect price should also be applied when changing the price, or removing limits. ie., de-activate them on the store shelf unless the profile option to auto-activate is enabled.

[Gobberwart]

OK, yeah that makes sense, although I can imagine there will be people who would disagree (ie. who will view it as an inconvenience rather than a player-protection measure). Perhaps two options are required:

1. Auto-activate on add new item
2. Deactivate on adding more of the same items with a different price/limit

I'll take a look at the code and see what can be done.

[mastechno]

I definetly like the deactivate on adding more of the same item, but at a different price! That would definetly help protect against the mispriced issues that will be bound to show up sooner or later.

[Gobberwart]

Indeed, and I've made the change. I haven't added yet another account option though. At this stage, if you have auto-activate enabled, it'll just accept whatever you enter, including updating existing item price/limit. If not, then it will disable existing items if you change the price or limit.

If there is demand for a second option, I can add it relatively easily, I just don't want to add too many options if they're not necessary.

[Grokly]

Many thanks!